Clean up some DI code #54732
Merged
Clean up some DI code #54732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidfowl
commented
Jun 25, 2021
davidfowl
commented
- Remove empty CreateInstanceCallSite file
- Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead.
- Added fast path if the value is already cached on the callsite.
- Remove empty CreateInstanceCallSite file - Removed ServiceScopeFactoryCallsite and used ConstantCallsite instead. - Added fast path if the value is already cached on the callsite.
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue Details
|
maryamariyan
approved these changes
Jun 25, 2021
pakrym
reviewed
Jun 25, 2021
src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/CallSiteValidator.cs
Show resolved
Hide resolved
pakrym
approved these changes
Jun 25, 2021
|
/azp list |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-dev-innerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-staging |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run dotnet-linker-tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test failures are unrelated. SocketsHttpHandler test timing out, mono interpreter test with System.Security.Cryptography.Xml.Tests are crashing. |
|
Perf regression in arm64: DrewScoggins/performance-2#7130 |
|
Perf improvements in arm64: DrewScoggins/performance-2#7137 |
|
So it both regressed and improved performance. I like it. |
|
Are the regressions expected? |
|
No, I'm not sure why it regressed. |
|
My guess is that this change #55340 fixed the regression. |
|
Looks to be the case: |
|
Excellent |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.